Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate typography API #1332

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Deprecate typography API #1332

merged 2 commits into from
Apr 4, 2024

Conversation

jamesmockett
Copy link
Contributor

What are you changing?

  • Deprecates typography API code and relocates to _deprecated.

Why?

  • Typography presets should be used instead to align with the design team.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b139cfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Apr 4, 2024
@jamesmockett jamesmockett linked an issue Apr 4, 2024 that may be closed by this pull request
Deprecate current typography API #1329
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Apr 4, 2024
@jamesmockett jamesmockett marked this pull request as ready for review April 4, 2024 14:49
@jamesmockett jamesmockett requested review from a team as code owners April 4, 2024 14:49
@jamesmockett jamesmockett merged commit b373253 into jm/type-preset-release-branch Apr 4, 2024
18 checks passed
@jamesmockett jamesmockett deleted the jm/deprecate-typography-api branch April 4, 2024 15:00
@sndrs sndrs mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate current typography API
1 participant
@jamesmockett